[SERVER-6193] string constants prevent optimization of non string sensitive operators Created: 24/Jun/12 Updated: 11/Jul/16 Resolved: 02/Oct/13 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Aggregation Framework |
| Affects Version/s: | None |
| Fix Version/s: | 2.5.3 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Aaron Staple | Assignee: | David Storch |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Participants: | |||||||||
| Description |
|
Observed behavior: The presence of a string in a $and/$or expression prevents optimization.
Test:
|
| Comments |
| Comment by auto [ 02/Oct/13 ] |
|
Author: {u'username': u'dannenberg', u'name': u'Matt Dannenberg', u'email': u'matt.dannenberg@10gen.com'}Message: Merge pull request #509 from dstorch/master
|
| Comment by auto [ 02/Oct/13 ] |
|
Author: {u'username': u'dstorch', u'name': u'David Storch', u'email': u'david.storch@10gen.com'}Message: |
| Comment by David Storch [ 01/Oct/13 ] |
| Comment by Matt Dannenberg [ 30/Sep/13 ] |
|
I think this is fixed and should be verified as part of QA-374. |
| Comment by Mathias Stearn [ 31/Jul/13 ] |
|
I think all you need to do is remove all of the string special casing in ExpressionNary::optimize, but you should also check each of the Expressions that defines a getFactory() to make sure that they are associative and commutative even with string arguments. |