[SERVER-61930] Individual health observers should return an error if a timeout period elapses when doing a single health check Created: 06/Dec/21  Updated: 29/Oct/23  Resolved: 16/Dec/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.3.0, 4.4.12

Type: New Feature Priority: Major - P3
Reporter: Lamont Nelson Assignee: Kshitij Gupta
Resolution: Fixed Votes: 0
Labels: pm-2364-faulty-mongos
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v5.2, v4.4
Participants:

 Description   

There are a number of ways to achieve this. We want this timeout to be a property of the health obsever so that individual observers can adjust it based on their use case. Below is an example:

  • Define the timeout period for a single health check as a property of health observers.
  • Define a type that takes a Future and timeout value as input, and returns a Future as output such that the returned Future is satisfied when the timeout period has expired or the input future is satisfied. Whichever comes first.
  • Wrap the future here with this new type.


 Comments   
Comment by Githook User [ 15/Feb/22 ]

Author:

{'name': 'Kshitij Gupta', 'email': 'kshitij.gupta@mongodb.com', 'username': 'kshitijng'}

Message: SERVER-61930: Individual health observers should return an error if a
timeout period elapses when doing a single health check.

(cherry picked from commit fa202b3594be0389f1fcd7e93e8f6d11ccb6e933)
Branch: v5.2
https://github.com/mongodb/mongo/commit/df259513aaee609d0ba6610dc9dc1780e976ce27

Comment by Githook User [ 15/Feb/22 ]

Author:

{'name': 'Kshitij Gupta', 'email': 'kshitij.gupta@mongodb.com', 'username': 'kshitijng'}

Message: SERVER-61930: Individual health observers should return an error if a timeout period elapses when doing a single health check

(cherry picked from commit c7e15b147b0d01f9b94fe7ebdaa92da39fc113ce)
Branch: v5.2
https://github.com/10gen/mongo-enterprise-modules/commit/6c7b7739d7fa39235a44b792974076e3eb26145a

Comment by Githook User [ 29/Dec/21 ]

Author:

{'name': 'Kshitij Gupta', 'email': 'kshitij.gupta@mongodb.com', 'username': 'kshitijng'}

Message: SERVER-61930: Individual health observers should return an error if a
timeout period elapses when doing a single health check.

(cherry picked from commit fa202b3594be0389f1fcd7e93e8f6d11ccb6e933)
Branch: v4.4
https://github.com/mongodb/mongo/commit/5579b1de0cacdccfbacac795b56b123ed20c9670

Comment by Githook User [ 16/Dec/21 ]

Author:

{'name': 'Kshitij Gupta', 'email': 'kshitij.gupta@mongodb.com', 'username': 'kshitijng'}

Message: SERVER-61930: Individual health observers should return an error if a
timeout period elapses when doing a single health check.
Branch: master
https://github.com/mongodb/mongo/commit/fa202b3594be0389f1fcd7e93e8f6d11ccb6e933

Comment by Githook User [ 16/Dec/21 ]

Author:

{'name': 'Kshitij Gupta', 'email': 'kshitij.gupta@mongodb.com', 'username': 'kshitijng'}

Message: SERVER-61930: Individual health observers should return an error if a timeout period elapses when doing a single health check
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/c7e15b147b0d01f9b94fe7ebdaa92da39fc113ce

Comment by Lamont Nelson [ 07/Dec/21 ]

The timeout value should be less than the progress monitor timeout, such that it allows multiple attempts before the progress monitor kicks in.

Generated at Thu Feb 08 05:53:42 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.