[SERVER-62056] Improve Sorter code structure Created: 14/Dec/21  Updated: 22/Aug/22  Resolved: 22/Aug/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Gregory Noma Assignee: Gregory Noma
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Sprint: Execution Team 2021-12-27, Execution Team 2022-01-24, Execution Team 2022-02-07, Execution Team 2022-02-21, Execution Team 2022-08-08
Participants:
Linked BF Score: 135

 Description   

The Sorter and its several related classes are all implemented in sorter.cpp. Some of them have confusing interfaces and lots of duplicated code, which can make them complicated to work with. This has caused pain and increased development time in recent history when we've had to modify these classes.



 Comments   
Comment by Gregory Noma [ 22/Aug/22 ]

I haven't had a chance to get back to this, and subsequent changes to the sorter would have to be taken into account on top of the previous attempt. I'm just going to close this for now; it can be re-opened if I (or anyone else) feel like taking a stab at this again in the future.

Comment by Githook User [ 30/Dec/21 ]

Author:

{'name': 'Yuhong Zhang', 'email': 'danielzhangyh@gmail.com', 'username': 'YuhongZhang98'}

Message: Revert "SERVER-62056 Improve `Sorter` code structure"

This reverts commit 4cfcc10775e2cab05a6e30c2516994ab67b9bd7d.
Branch: master
https://github.com/mongodb/mongo/commit/23166382f8f7d7c9ed322e590e5020d37a29b540

Comment by Githook User [ 16/Dec/21 ]

Author:

{'name': 'Gregory Noma', 'email': 'gregory.noma@gmail.com', 'username': 'gregorynoma'}

Message: SERVER-62056 Improve `Sorter` code structure
Branch: master
https://github.com/mongodb/mongo/commit/4cfcc10775e2cab05a6e30c2516994ab67b9bd7d

Generated at Thu Feb 08 05:54:02 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.