[SERVER-62193] Improve insert_vector secondary performance Created: 20/Dec/21  Updated: 06/Dec/22

Status: Open
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Matthew Russotto Assignee: Backlog - Replication Team
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-59776 50% regression in single multi-update Closed
is related to SERVER-61843 Figure out what is going on with our ... Closed
is related to SERVER-65054 Avoid slow insert batches blocking re... Open
Assigned Teams:
Replication
Participants:

 Description   

In SERVER-39950 we merged some redundant code paths between sync tail and initial sync. In doing so we lost some optimizations which affect the insert_vector test performance on secondaries.

The largest effect is probably the extra copy of the batch here

https://github.com/10gen/mongo/blob/857e5ff84b57167abcfb875c56a3cda1464de563/src/mongo/db/repl/oplog_batcher.cpp#L296

But also note this pre-allocation may not be useful after removing that

https://github.com/10gen/mongo/blob/8c11a9d7c59a156619ba387be14eb584f979442a/src/mongo/db/repl/oplog_batcher.h#L50

whereas pre-allocation here may be helpful

https://github.com/10gen/mongo/blob/857e5ff84b57167abcfb875c56a3cda1464de563/src/mongo/db/repl/oplog_batcher.cpp#L160


Generated at Thu Feb 08 05:54:26 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.