[SERVER-62323] Reorder data members of TestFixture found at src/mongo/transport/transport_layer_asio_test.cpp Created: 30/Dec/21  Updated: 12/Apr/22  Resolved: 17/Feb/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.0.8

Type: Bug Priority: Major - P3
Reporter: Daniel Morilha (Inactive) Assignee: Matt Diener (Inactive)
Resolution: Done Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Operating System: ALL
Backport Requested:
v5.0
Sprint: Service Arch 2022-2-21, Service Arch 2022-03-07
Participants:
Linked BF Score: 21
Story Points: 1

 Description   

BF-57427 came as an infrequent crash at the underlying ASIO synchronization mechanisms happening in windows. Upon investigation, it was found that the destruction order of TestFixture' s data members located at src/mongo/transport/transport_layer_asio_test.cpp could be related, as the underlying library tries to invalidly write to an address supposedly owned by an object in this class.

 

The proposed solution is to simply re-order the data members. Preliminary tests didn't show any direct regression : Evergreen - Version Patch 8 by daniel.morilha (mongodb.com)



 Comments   
Comment by Githook User [ 11/Apr/22 ]

Author:

{'name': 'Matt Diener', 'email': 'matt.diener@mongodb.com', 'username': 'mattdiener'}

Message: SERVER-62323 Swap destructor ordering in transport_layer_asio_test.cpp

(cherry picked from commit e3790c75b13f6717f74b35d8f2bb7726224bd5a8)
Branch: v5.0
https://github.com/mongodb/mongo/commit/ddcc9651349ad31129c508e5e754e626a8444b2a

Comment by Githook User [ 14/Feb/22 ]

Author:

{'name': 'Matt Diener', 'email': 'matt.diener@mongodb.com', 'username': 'mattdiener'}

Message: SERVER-62323 Swap destructor ordering in transport_layer_asio_test.cpp
Branch: master
https://github.com/mongodb/mongo/commit/e3790c75b13f6717f74b35d8f2bb7726224bd5a8

Comment by Matt Diener (Inactive) [ 10/Feb/22 ]

I managed to reproduce the BF consistently on an Evergreen host. daniel.morilha's patch works great! Moving forward on pushing it.

Generated at Thu Feb 08 05:54:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.