[SERVER-62350] replace usage of read_before_oldest with reset_snapshot Created: 04/Jan/22 Updated: 29/Oct/23 Resolved: 11/Feb/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | None |
| Fix Version/s: | 5.3.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Eric Milkie | Assignee: | Jordi Olivares Provencio |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Sprint: | Execution Team 2022-02-07, Execution Team 2022-02-21 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Description |
|
WiredTigerRecoveryUnit::refreshSnapshot() was originally written prior to the existence of WiredTiger reset_snapshot() functionality. We can now rewrite refreshSnapshot() to utilize reset_snapshot(). This also has the added benefit of removing usage of the read_before_oldest configuration parameter to begin_transaction; there is a desire to remove this API from future WT versions. Thus, the work for this ticket should include removing the read_before_oldest usage from wiredtiger_begin_transaction_block.cpp. |
| Comments |
| Comment by Githook User [ 11/Feb/22 ] |
|
Author: {'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}Message: |
| Comment by Jordi Olivares Provencio [ 08/Feb/22 ] |
|
Thanks keith.bostic! I'll rebase my work on that commit and test it out again. |
| Comment by Keith Bostic (Inactive) [ 08/Feb/22 ] |
|
jordi.olivares-provencio, I just merged Let us know if we can assist in any way. – Thanks! |
| Comment by Jordi Olivares Provencio [ 07/Feb/22 ] |
|
It seems that WT is too restrictive in how it defines a write transaction. We've opened |
| Comment by Alexander Gorrod [ 05/Jan/22 ] |
|
A vote in favor of getting this done quickly. Making this change will allow WiredTiger to remove an API that, if misused, could lead to incorrect data being returned to readers. |