[SERVER-62637] Find a way to avoid running shardMerge js tests for community build variants. Created: 14/Jan/22  Updated: 31/Aug/23  Resolved: 31/Aug/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Suganthi Mani Assignee: Suganthi Mani
Resolution: Duplicate Votes: 0
Labels: shard-merge-cleanup
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-57896 Enable Feature flag for Shard Merge Closed
Duplicate
duplicates SERVER-57896 Enable Feature flag for Shard Merge Closed
Related
is related to SERVER-60684 Exclude Tests and Tasks tagged with "... Open
Assigned Teams:
Serverless
Sprint: Server Serverless 2023-01-23, Server Serverless 2023-02-06, Server Serverless 2023-02-20, Server Serverless 2023-03-06, Server Serverless 2023-03-20, Server Serverless 2023-04-03, Server Serverless 2023-04-17
Participants:

 Description   

Our shard Merge implementation + it's related unit & js tests are located in the community repo but depends on enterprise-only feature, like, backup cursor. If we run those tests on a non-enterprise build variant, those tests would fail.

Currently the shard Merge implementation is behind a feature flag. And, we run all feature flags enabled only on enterprise-only build variants. However, we are safe now as we don't run shard merge tests on non-enterprise build variant. But, once we enable the shardMerge flag, we would start seeing test failures w/ error message -

 "Unrecognized pipeline stage name: '$backupCursor'" 



 Comments   
Comment by Suganthi Mani [ 30/Aug/23 ]

Just adding a comment in response to option#2. Running shard merge unit tests in community build variant doesn't fail because it uses mock backup cursor Although it's ideal to exclude enterprise-only feature tests from the community build version, given that we already have the shard merge code in the community build, including its tests in the community repository is ok.

Comment by Steven Vannelli [ 17/Apr/23 ]

Putting this into the following sprint to see if anyone has capacity to pick it up.

Comment by Suganthi Mani [ 08/Mar/23 ]

Since Matt is busy with cgroup spike , removing this ticket from his plate.

Comment by A. Jesse Jiryu Davis [ 30/Jan/22 ]

Now we've tagged all multitenant migrations tests with "serverless" (SERVER-60684), perhaps exclude "serverless" tests from community variants. But I still don't know the answer for C++ unittests, maybe Option 1 is right for them.

Comment by A. Jesse Jiryu Davis [ 14/Jan/22 ]

I want to reuse the existing multitenant migration JS tests, so let's try to do Option 2. Let's use (or create) a JS test tag like "requires_enterprise". For C++ unittests I don't know the solution yet.

Comment by Suganthi Mani [ 14/Jan/22 ]

Proposals:
Option#1: Do we want to move the tenant migration test to enterprise repo?
Option#2 : Can we add some tag to prevent the tenant migration test (specifically after shardMerge feature flag is enabled) to run on a non-enterprise build variant? (This won't work for unit(cpp) tests)

CC jesse

Generated at Thu Feb 08 05:55:39 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.