[SERVER-62783] Reduce the number of parsing/serialisation methods in ChunkVersion Created: 20/Jan/22 Updated: 29/Oct/23 Resolved: 25/Jan/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 5.3.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Kaloian Manassiev | Assignee: | Kaloian Manassiev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Sharding EMEA 2022-02-07 |
| Participants: |
| Description |
|
Currently, there are 7 parsing and 6 serialisation method each with a subtle difference and check from the previous. However, fundamentally, there are only two types of chunk version BSONs that can possibly be generated: The "legacy" format, which persists the version as fields within a BSON object (with the epoch being optional for chunk values, which have come from an upgrade that started at 2.2). The "new" format, which is a BSONArray. Under this ticket, we should ensure that there are only two variants of parse/serialise methods |
| Comments |
| Comment by Githook User [ 26/Jan/22 ] |
|
Author: {'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}Message: This allows one more method to be thrown out. |
| Comment by Githook User [ 25/Jan/22 ] |
|
Author: {'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}Message: Special-case the generation of the {0:minor|major, 1:epoch, ...} format |
| Comment by Githook User [ 24/Jan/22 ] |
|
Author: {'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}Message: |
| Comment by Githook User [ 24/Jan/22 ] |
|
Author: {'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}Message: |
| Comment by Githook User [ 24/Jan/22 ] |
|
Author: {'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}Message: |
| Comment by Githook User [ 24/Jan/22 ] |
|
Author: {'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}Message: |