[SERVER-62791] Improve performance of WiredTigerRecoveryUnit::setTimestamp Created: 20/Jan/22 Updated: 29/Oct/23 Resolved: 07/Feb/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.3.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Donald Anderson | Assignee: | Jordi Olivares Provencio |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Sprint: | Execution Team 2022-02-07, Execution Team 2022-02-21 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Linked BF Score: | 135 | ||||||||||||||||
| Description |
|
The performance of setTimestamp can be improved by using a stack buffer and simple formatting (like snprintf). Rationale: setTimestamp sometimes pops up in performance critical paths (see HELP-28951). In |
| Comments |
| Comment by Githook User [ 07/Feb/22 ] | ||||||||||||||||
|
Author: {'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}Message: | ||||||||||||||||
| Comment by Githook User [ 04/Feb/22 ] | ||||||||||||||||
|
Author: {'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}Message: Revert " This reverts commit 3f0788882675f8e4893a9c5ebbcee4716ed436fa. | ||||||||||||||||
| Comment by Githook User [ 04/Feb/22 ] | ||||||||||||||||
|
Author: {'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}Message: | ||||||||||||||||
| Comment by Donald Anderson [ 20/Jan/22 ] | ||||||||||||||||
|
louis.williams, sure, as long as it doesn't imply memory allocation. Whatever unsignedHex calls is doing a new, which implies tcmalloc memory allocation, so it's running slow. | ||||||||||||||||
| Comment by Donald Anderson [ 20/Jan/22 ] | ||||||||||||||||
|
Here's what I was thinking (untested code):
| ||||||||||||||||
| Comment by Louis Williams [ 20/Jan/22 ] | ||||||||||||||||
|
We made some changes in the past ( |