[SERVER-62829] query_hash_stability.js should not run in passthrough suites that do downgrades Created: 20/Jan/22  Updated: 29/Oct/23  Resolved: 24/Jan/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.3.0, 5.2.1

Type: Bug Priority: Major - P3
Reporter: David Storch Assignee: David Storch
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Related
is related to SERVER-56980 Robustify jstests/core/query_hash_sta... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v5.2
Sprint: QE 2022-02-07, QE 2022-01-24
Participants:
Linked BF Score: 50

 Description   

The query_hash_stability.js integration test verifies that the "planCacheKey" as reported by explain remains stable for a given set of indexes. However, the plan cache key encoding is permitted to change between different versions of the server. One recent example is that the plan cache key is encoded slightly differently for queries using the SBE execution engine than for queries using the classic execution engine. Therefore, if a user downgrades from 5.2 (where SBE is enabled) to 5.0 (where SBE is disabled), then the "planCacheKey" will change for queries eligible for SBE.

This means that query_hash_stability.js cannot run in test passthrough suites that perform downgrades while the test is running. The test could obtain the plan cache key for a query on 5.2, then a downgrade could occur, and then the test obtains the plan cache key again and expects it to remain the same as before. To prevent this from occurring we should blocklist this test from passthrough suites that involve downgrades. This includes at least the following suites:

  • change_streams_downgrade
  • retryable_writes_downgrade
  • sharded_retryable_writes_downgrade


 Comments   
Comment by Githook User [ 24/Jan/22 ]

Author:

{'name': 'David Storch', 'email': 'david.storch@mongodb.com', 'username': 'dstorch'}

Message: SERVER-62829 Prevent query_hash_stability.js from running in downgrade passthroughs

(cherry picked from commit 9343d1633ab6dfa162dc494e13152d13c40fb1a2)
Branch: v5.2
https://github.com/mongodb/mongo/commit/6a4628b52a227e1100df8facb3a048c972debfb1

Comment by Githook User [ 24/Jan/22 ]

Author:

{'name': 'David Storch', 'email': 'david.storch@mongodb.com', 'username': 'dstorch'}

Message: SERVER-62829 Prevent query_hash_stability.js from running in downgrade passthroughs
Branch: master
https://github.com/mongodb/mongo/commit/9343d1633ab6dfa162dc494e13152d13c40fb1a2

Generated at Thu Feb 08 05:56:10 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.