[SERVER-63331] Use a proper IDL structure for the write commands' error reporting Created: 07/Feb/22  Updated: 29/Oct/23  Resolved: 28/Feb/22

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 6.0.0-rc0

Type: Task Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Kaloian Manassiev
Resolution: Fixed Votes: 0
Labels: PM-2144-Milestone-0
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-63327 Remove usages of the StaleShardVersio... Closed
Problem/Incident
causes SERVER-64078 Missing ErrMsg for Multiple Bulk Writ... Closed
Backwards Compatibility: Fully Compatible
Sprint: Sharding EMEA 2022-02-21, Sharding EMEA 2022-03-07
Participants:

 Description   

The BatchCommandResponse class uses its own custom parsing which makes it difficult to make changes or to inspect what is the format of the write commands. We should switch all places that currently use BatchCommandResponse to instead use the IDL-based parsers and generators instead.

As part of this ticket we should make the write errors not be a BSON object, but a proper IDL structure.



 Comments   
Comment by Githook User [ 27/Feb/22 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-63331 Remove unnecessary conversion between BSON and WriteError IDL
Branch: master
https://github.com/mongodb/mongo/commit/1d009ac1fe9e1baad6db051eb6a245f314619222

Comment by Githook User [ 26/Feb/22 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: Revert "SERVER-63331 Remove unnecessary conversion between BSON and WriteError IDL"

This reverts commit 8aca92da9115a723c9f4c16be96c64cdb4b8362b.
Branch: master
https://github.com/mongodb/mongo/commit/fcad5cd7a9267980fefda51b1e4a3db0a12000ec

Comment by Githook User [ 25/Feb/22 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-63331 Remove unnecessary conversion between BSON and WriteError IDL
Branch: master
https://github.com/mongodb/mongo/commit/8aca92da9115a723c9f4c16be96c64cdb4b8362b

Comment by Githook User [ 23/Feb/22 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-63331 Convert WriteErrors parsing into IDL
Branch: master
https://github.com/mongodb/mongo/commit/23d4be01ca042cd28d0d616f9334e02598e79510

Comment by Githook User [ 07/Feb/22 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-63331 Remove useless methods from BatchCommandResponse
Branch: master
https://github.com/mongodb/mongo/commit/522da292b8e89d6288916f744f318cb1f32ac8a8

Generated at Thu Feb 08 05:57:30 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.