[SERVER-63477] TEST_LIST targets should not depend on the tests themselves Created: 09/Feb/22 Updated: 27/Oct/23 Resolved: 27/Oct/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.0 Desired |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Mathias Stearn | Assignee: | [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive) |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Server Development Platform
|
| Participants: |
| Description |
|
Right now TEST_LIST targets such as build/unittests.txt depend on all of the tests in the list, meaning that it will be rebuilt every time any unittest is recompiled. But its contents don't actually depend on those tests, it only depends on the names of the files, and that is encoded in the command to run. Since ninja automatically considers the text of the command and rspfile_content as the equivalent of an input (in that if they change, the target is considered dirty and will be rebuilt), these targets don't need any actual inputs. While you are in there, it would probably be slightly more efficient to use this command since it will spawn many fewer processes: echo "$files" | tr ' ' '\n' > $out. |
| Comments |
| Comment by Mathias Stearn [ 02/Mar/22 ] |
|
Sorry, must have misclicked. |
| Comment by Andrew Morrow (Inactive) [ 01/Mar/22 ] |
|
redbeard0531 - Did you mean to leave this assigned to yourself or did you want it to go to SDP? |