[SERVER-63628] IDL override_set generates unnecessary code Created: 14/Feb/22  Updated: 29/Oct/23  Resolved: 10/Mar/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.0.0-rc0

Type: Bug Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-63588 IDL applies redaction to incoming Ser... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Service Arch 2022-2-21, Service Arch 2022-03-07, Service Arch 2022-03-21
Participants:

 Description   

When IDL does not specify a user-defined set override for a ServerParameter, it provides a default by generating a body for it, but all bodies are identical, and this would be easier to do by inheritance, and simply not mentioning the set override if there isn't one, and a base-defined default would kick in.



 Comments   
Comment by Billy Donahue [ 21/Feb/22 ]

Currently the set overloads generated by IDL differ by whether the property is redacted. But this is actually incorrect. When SERVER-63588 fixes the improper redaction, there will be no difference among all the autogenerated set overloads and they might as well just use an inherited implementation. So this ticket can be fixed by the same commit that fixes SERVER-63588, really.

Generated at Thu Feb 08 05:58:15 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.