[SERVER-63658] Refactor ViewsForDatabase to convert public class variables to private Created: 15/Feb/22 Updated: 27/Oct/23 Resolved: 07/Jun/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Dianna Hohensee (Inactive) | Assignee: | Gregory Noma |
| Resolution: | Gone away | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Storage Execution
|
||||||||
| Sprint: | Execution Team 2023-06-12 | ||||||||
| Participants: | |||||||||
| Description |
|
In 1) "I really like separating out ViewsForDatabase into its own thing, but the public variables here bother me. We don't normally have public class variables – only in simple structs, and this type warrants a class with all the other logic. And it's really tricky looking at the .cpp file and discerning that these are class variables without the usual underscore prefix signal – e.g. _viewMap, _ignoreExternChange, etc. Is there a way we could make these private and add helper functions for access? Like from a brief look at the usage, looks like a clear() function and some getters at least." 2) "Could we rename 'durable' to 'durableViewCatalog' while we're here? Seeing durable->iterate(..) in the .cpp file made me go "huh?" Named like a boolean." |
| Comments |
| Comment by Gregory Noma [ 07/Jun/23 ] |
|
This was addressed by |