[SERVER-63754] avoid copying NamespaceStringOrUUID vector in OptionsWithSecondaryCollections Created: 16/Feb/22 Updated: 29/Oct/23 Resolved: 17/Jul/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Benety Goh | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Assigned Teams: |
Storage Execution
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Sprint: | Execution NAMR Team 2023-07-24 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Description |
|
Currently to provide a list of secondary namespaces to the `AutoGetCollection` RAII types, we pass a copy of the secondary namespaces to OptionsWithSecondaryCollections. This vector of namespaces is not retained by the RAII type after constructing the `AutoGet` object. As proposed in a comment on this ticket, it would be nice to provide a way for the constructor to accept iterators into an existing vector of secondary namespaces rather than have to make a copy of the entire vector. ====== OLD DESCRIPTION ====== In |
| Comments |
| Comment by Githook User [ 17/Jul/23 ] | ||||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: | ||||||||
| Comment by Githook User [ 16/Jul/23 ] | ||||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: | ||||||||
| Comment by Githook User [ 16/Jul/23 ] | ||||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: | ||||||||
| Comment by Githook User [ 15/Jul/23 ] | ||||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: | ||||||||
| Comment by Githook User [ 15/Jul/23 ] | ||||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: | ||||||||
| Comment by Benety Goh [ 13/Jul/23 ] | ||||||||
|
Re-opening to consider adopting Dianna's proposal for modifiying the AutoGet constructor to accept iterators into the vector of namespaces. | ||||||||
| Comment by Benety Goh [ 12/Jul/23 ] | ||||||||
|
Part of the reason for closing this ticket as "Gone Away" is due to the introduction of OptionsWithSecondaryCollections in | ||||||||
| Comment by Dianna Hohensee (Inactive) [ 01/Mar/22 ] | ||||||||
|
Spoke with Benety and Henrik. The proposal is the addition of a new constructor that specifically supports this caller pattern to avoid copying the input secondary namespace vector Suggested constructor:
Caller pattern:
|