[SERVER-63774] Pass optional dbVersion to runPipelineOnSpecificShard Created: 17/Feb/22 Updated: 29/Oct/23 Resolved: 03/Mar/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.0.0-rc0, 4.4.18, 4.2.24, 5.0.13 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Jennifer Peshansky (Inactive) | Assignee: | Jennifer Peshansky (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | pm-2419-commit | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||||||
| Sprint: | QE 2022-03-07 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Description |
|
Error: cm uninitialized
|
| Comments |
| Comment by Githook User [ 08/Nov/22 ] |
|
Author: {'name': 'Mickey. J Winters', 'email': 'mickey.winters@mongodb.com', 'username': 'mjrb'}Message:
both modified: src/mongo/s/query/cluster_aggregate.cpp (cherry-picked from commit e424f3ed1266bcd772c52bcf23c518b2fe6c83ab) |
| Comment by Githook User [ 31/Oct/22 ] |
|
Author: {'name': 'Mickey. J Winters', 'email': 'mickey.winters@mongodb.com', 'username': 'mjrb'}Message:
(cherry-picked from commit 4d5451b20fecaf4a054cca94de6962fcf28c577f) |
| Comment by Githook User [ 07/Sep/22 ] |
|
Author: {'name': 'Mickey. J Winters', 'email': 'mickey.winters@mongodb.com', 'username': 'mjrb'}Message:
(cherry-picked from commit fc54ebd0137a25ea664c022b51b685667dd037c7) |
| Comment by Githook User [ 03/Mar/22 ] |
|
Author: {'name': 'Jennifer Peshansky', 'email': 'jennifer.peshansky@mongodb.com', 'username': 'jenniferpeshansky'}Message: |
| Comment by Jennifer Peshansky (Inactive) [ 28/Feb/22 ] |
|
The cleanest solution here seems to be removing the logic for adding versioning information from this function, and instead assume the versioning information has already been added. The caller functions can add it as necessary. That way, we avoid passing an optional chunkManager or an optional dbVersion. However, we first have to investigate how invasive it would be to pass this responsibility onto the callers of this function. |
| Comment by Mickey Winters [ 24/Feb/22 ] |
|
I symbolized a stack trace really quick to make sure another test was the same issue. it seems like in sometimes we try to pass a chunk manager to runPipelineOnSpecificShardOnly in cluster_aggregate which causes the invariant trying to get an uninitialized optional. we only actually use the chunk manager in the case that we are not doing a per shard cursor, so maybe we can just make it an optional and runPipelineOnPrimaryShard can pass it in for its purposes. If this is appropriate this would be a quick fix |