[SERVER-64131] Turn on WT write_timestamp_usage assertions for release builds Created: 02/Mar/22  Updated: 09/Aug/22  Resolved: 09/Aug/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Daniel Gottlieb (Inactive) Assignee: Daniel Gottlieb (Inactive)
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
depends on WT-8876 Make timestamp usage checking at comm... Closed
Backport Requested:
v6.0
Participants:

 Description   

WT-8876 will introduce a default write_timestamp_usage of ordered. As we only set write_timestamp_usage on test runs, we should prepare for the change by setting the usage in all circumstances.

Additionally we may want to set the sizeStorer to a usage of `none`.

Some background: with WT-8876, WT's behavior on a MDB release build w.r.t: write_timestamp_usage will be to:

  • default to `ordered` if one is not specified. This is an in-memory setting and not persisted.
  • If an violation is found: log an error
  • succeed the transaction

This keeps the behavior as we have it today. Assuming our existing test coverage is complete (where these assertions fail tests), we expect no log lines to emitted.

After confirming there are no new log lines, WT can change behavior to fail commits if the write_timestamp_usage assertion isn't satisfied.

This ticket should also take care in setting the write_timestamp_usage back to none (or disabling its assertion/verbose settings) when shutting down with a downgraded FCV. Generally speaking, everytime we strengthen an assertion in a new release there must be accompanying code to relax it on downgrade.



 Comments   
Comment by Daniel Gottlieb (Inactive) [ 09/Aug/22 ]

SERVER-65971 instead opts to turn on timestamp assertions by default. Individual WT transactions can opt out of being checked.

Generated at Thu Feb 08 05:59:35 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.