[SERVER-64150] Clarify how to pass resmoke options through to burn_in_tests.py Created: 03/Mar/22  Updated: 23/Mar/22  Resolved: 23/Mar/22

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Max Hirschhorn Assignee: Zituo Jin
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Sprint: DAG 2022-03-21, DAG 2022-04-04
Participants:
Story Points: 2

 Description   

It looks like attempting to specify any resmoke options to burn_in_tests.py requires including the python buildscripts/resmoke.py run incantation as well. From a Slack discussion it wasn't clear if this was intentional or not. We should either simplify how resmoke options are consumed so it isn't necessary or explicitly document how to specify additional arguments.

python buildscripts/burn_in_tests.py -- python buildscripts/resmoke.py run --dbpathPrefix /some/other/directory

Also note that the -- is necessary because the click command isn't being configured to ignored unrecognized arguments despite using click.UNPROCESSED. https://click.palletsprojects.com/en/latest/advanced/#forwarding-unknown-options

def _set_resmoke_cmd(repeat_config: RepeatConfig, resmoke_args: [str]) -> [str]:
    """Build the resmoke command, if a resmoke.py command wasn't passed in."""
    new_args = [sys.executable, "buildscripts/resmoke.py", "run"]
    if resmoke_args:
        new_args = copy.deepcopy(resmoke_args)

https://github.com/mongodb/mongo/blob/b8f41786600e9033fac0a3ccc0c9e8018b5dc8ca/buildscripts/burn_in_tests.py#L315-L319



 Comments   
Comment by Githook User [ 23/Mar/22 ]

Author:

{'name': 'Zituo Jin', 'email': 'zituo.jin@mongodb.com', 'username': 'zituo-jin'}

Message: SERVER-64150 Simplify how to pass resmoke options to burn_in_tests
Branch: master
https://github.com/mongodb/mongo/commit/613c7322cd303d548744de30ce706012a9b2247d

Generated at Thu Feb 08 05:59:38 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.