[SERVER-64180] Create JS tests that validate semantics of $lookup in SBE Created: 03/Mar/22 Updated: 29/Oct/23 Resolved: 07/Apr/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.0.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Irina Yatsenko (Inactive) | Assignee: | Irina Yatsenko (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | QE 2022-04-04, QE 2022-04-18 |
| Participants: |
| Description |
|
We currently don't enable lookup lowering in all-feature-flags BV because too many cases aren't implemented yet. Eventually, running the existing $lookup tests in classical BV and in all-feature-flags BV (and later, with the default flags) will provide the coverage but until then we should have a test that explicitly sets the flag and covers the basics of $lookup semantics in SBE. Note: lookup_pushdown.js does set the flag explicitly and checks the explain output. It might be possible to test the semantics at the same time, but the test will likely need to be rewritten to be more data-driven. |
| Comments |
| Comment by Githook User [ 05/Apr/22 ] |
|
Author: {'name': 'Irina Yatsenko', 'email': 'irina.yatsenko@mongodb.com', 'username': 'IrinaYatsenko'}Message: |
| Comment by Irina Yatsenko (Inactive) [ 31/Mar/22 ] |
|
We've enabled $lookup lowering in all-feature-flags BV so don't need a separate set of tests for this. However, should look into forcing a specific join strategy to run the tests for all three of them w/o having to maintain multiple test-files. |
| Comment by Rui Liu [ 10/Mar/22 ] |
|
SERVER-63572 introduced some semantic testing for index join with scalar local type. |
| Comment by Ethan Zhang (Inactive) [ 08/Mar/22 ] |
|
With the $lookup close to running E2E this week I am no longer sure we should still prioritize this now compared to the other remaining work in the project, although I think the work this ticket asks for has a lot of value. |