[SERVER-64500] Change src/mongo/db/commands/shutdown.cpp finishShutdown timeout from "long long" to "Milliseconds" duration Created: 14/Mar/22  Updated: 31/Mar/22  Resolved: 31/Mar/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Daniel Morilha (Inactive) Assignee: Daniel Morilha (Inactive)
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by SERVER-63198 Prevent shutdown command from hanging Closed
Sprint: Service Arch 2022-03-21, Service Arch 2022-04-04, Service Arch 2022-04-18
Participants:
Story Points: 1

 Description   

finishShutdown uses "long long" type to represent the amount of time before the shutdown is considered timeout. Modern C++ expects time durations to be represented as a unit of time like Milliseconds.

Acceptance Criteria: Change the method signature, all callers and callees.



 Comments   
Comment by Daniel Morilha (Inactive) [ 31/Mar/22 ]

as per Billy's suggestion.

Comment by Billy Donahue [ 15/Mar/22 ]

SERVER-63198 should change this. It shouldn't be done in a separate ticket.
There is only one caller and SERVER-63198 already changes that caller to add a parameter to it.
I suggest closing this one.

Generated at Thu Feb 08 06:00:29 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.