[SERVER-64664] ninja tool should not consider install files generated source Created: 18/Mar/22 Updated: 29/Oct/23 Resolved: 13/Apr/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.3.2, 5.0.9, 4.4.15 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Daniel Moody | Assignee: | Daniel Moody |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Backport Requested: |
v5.3, v5.0, v4.4
|
||||||||||||||||||||
| Sprint: | Dev Platform 2022-04-04, Dev Platform 2022-04-18 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Description |
|
The ninja tool looks at any output with a header file as generated source. However install edges have outputs with header files, and they get labeled as generated source. This can cause circular dependencies in a few edge cases, and should be a general improvement. Possible fix is just checking for the "INSTALL" rule when determining if a file is generated source:
|
| Comments |
| Comment by Githook User [ 26/Apr/22 ] |
|
Author: {'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}Message: (cherry picked from commit 2fef432fa6e7cf3fd4f22ba3b193222c2887f14f) |
| Comment by Githook User [ 25/Apr/22 ] |
|
Author: {'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}Message: (cherry picked from commit 2fef432fa6e7cf3fd4f22ba3b193222c2887f14f) |
| Comment by Githook User [ 25/Apr/22 ] |
|
Author: {'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}Message: (cherry picked from commit 2fef432fa6e7cf3fd4f22ba3b193222c2887f14f) |
| Comment by Githook User [ 11/Apr/22 ] |
|
Author: {'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}Message: |
| Comment by Andrew Morrow (Inactive) [ 19/Mar/22 ] |
|
I like this as a workaround, and I think richard.samuels can just implement it as part of his work on So, what makes a source "generated"? How do we distinguish them from other generated things, like object files, which also become in some sense sources, but are not generated in the same way as the things we currently consider "generated sources". |