[SERVER-64821] Change unstable to true for fields that are not meant to be included in the stable API Created: 23/Mar/22 Updated: 29/Oct/23 Resolved: 01/Apr/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.0.0-rc0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Huayu Ouyang | Assignee: | Huayu Ouyang |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Sprint: | Repl 2022-04-04 | ||||||||
| Participants: | |||||||||
| Description |
|
We should change recordPreImages, ignoreUnknownIndexOptions, We may also need to add them to the IGNORE_UNSTABLE_LIST. The changes from https://github.com/mongodb/mongo/commit/e818cd876ed3b492517400a3da3f687fbe13d8aa had added unstable:false to a number of command parameters, but recordPreImages is intentionally undocumented and only used by Realm, so it should be changed back to unstable: true. https://github.com/mongodb/mongo/blob/330c702d55b4a2cfb98dd86630c7e7820e5657c1/src/mongo/db/coll_mod.idl#L155-L160 Edit: We cannot change isTimeseriesNamespace or runtimeConstants in update and findAndModify to unstable: true at this moment because it needs to be stable to pass parsing validation in shards. See |
| Comments |
| Comment by Githook User [ 31/Mar/22 ] | |||||||||||||||||||||||||||
|
Author: {'name': 'Huayu Ouyang', 'email': 'huayu.ouyang@mongodb.com', 'username': 'huayu-ouyang'}Message: | |||||||||||||||||||||||||||
| Comment by Huayu Ouyang [ 23/Mar/22 ] | |||||||||||||||||||||||||||
|
Thanks for catching these! I'll edit the ticket to also change ignoreUnknownIndexOptions, isTimeseriesNamespace, runtimeConstants to unstable: true | |||||||||||||||||||||||||||
| Comment by Charlie Swanson [ 23/Mar/22 ] | |||||||||||||||||||||||||||
|
I can confirm #3 - It looks like the write_ops.idl file diverges from the same options in the aggregate_command.idl file:
'let' and 'runtimeConstants' provide the same functionality and 'let' should be preferred. | |||||||||||||||||||||||||||
| Comment by Max Hirschhorn [ 23/Mar/22 ] | |||||||||||||||||||||||||||
|
I skimmed the remainder of the changes of e818cd8 and think a few more changes may be needed to reflected our documented API.
|