[SERVER-64832] Have MDB unittests using WT enable logging Created: 23/Mar/22  Updated: 29/Oct/23  Resolved: 07/Apr/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.0.0-rc0

Type: Task Priority: Major - P3
Reporter: Daniel Gottlieb (Inactive) Assignee: Daniel Gottlieb (Inactive)
Resolution: Fixed Votes: 0
Labels: auto-reverted
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-65146 Run unit tests with wiredTiger by def... Closed
Gantt Dependency
has to be done before WT-6356 Change WiredTiger MDB timestamp defau... Closed
has to be done before WT-9055 Remove out-of-order timestamp support Closed
Problem/Incident
Backwards Compatibility: Fully Compatible
Participants:
Linked BF Score: 178

 Description   

WT is changing behavior/assertions around timestamps. Timestamp behavior is sensitive to logging settings. Our unittests should run with logging enabled to better emulate the production behaviors our unittests are intending to assert against.



 Comments   
Comment by Githook User [ 07/Apr/22 ]

Author:

{'name': 'Daniel Gottlieb', 'email': 'daniel.gottlieb@mongodb.com', 'username': 'dgottlieb'}

Message: SERVER-64832: Convert WT unittests to use replica set logging settings.

Some unittests operate against an oplog-like collection while others operate
on a regular user-like collection. We now more intentionally set logging
settings to mimic the replica set behavior a test intends to work with.

Additionally, this patch removes the "must be timestamped" sanity checks and
assertions. WiredTiger has implemented the corollary checks. WiredTiger can
better perform these `write_timestamp_usage` assertions. WiredTiger's `ordered`
checks have the benefit of asserting not only that an update is timestamped,
but that the timestamp value is non-descending for any given update chain.
Branch: master
https://github.com/mongodb/mongo/commit/bf6504dcdbc684d34c4ca0b0055f1bf476bb7903

Comment by xgen-buildbaron-user [ 07/Apr/22 ]

Ticket re-opened due to revert. run_unittests began a consistent failure of build/install/bin/storage_wiredtiger_record_store_and_index_test

Comment by Githook User [ 07/Apr/22 ]

Author:

{'name': 'auto-revert-processor', 'email': 'dev-prod-dag@mongodb.com'}

Message: Revert "SERVER-64832: Convert WT unittests to use replica set logging settings."

This reverts commit f8b4247e38f3ac7fd3dc37b3031469b2d1c53999.
Branch: master
https://github.com/mongodb/mongo/commit/be4ed43dc2b31c4f7ef607fb4556bb1991f9dfad

Comment by Githook User [ 06/Apr/22 ]

Author:

{'name': 'Daniel Gottlieb', 'email': 'daniel.gottlieb@mongodb.com', 'username': 'dgottlieb'}

Message: SERVER-64832: Convert WT unittests to use replica set logging settings.

Some unittests operate against an oplog-like collection while others operate
on a regular user-like collection. We now more intentionally set logging
settings to mimic the replica set behavior a test intends to work with.

Additionally, this patch removes the "must be timestamped" sanity checks and
assertions. WiredTiger has implemented the corollary checks. WiredTiger can
better perform these `write_timestamp_usage` assertions. WiredTiger's `ordered`
checks have the benefit of asserting not only that an update is timestamped,
but that the timestamp value is non-descending for any given update chain.
Branch: master
https://github.com/mongodb/mongo/commit/f8b4247e38f3ac7fd3dc37b3031469b2d1c53999

Generated at Thu Feb 08 06:01:15 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.