[SERVER-64882] Eliminate fallback code which uses the classic cache when the SBE cache is disabled Created: 24/Mar/22 Updated: 29/Oct/23 Resolved: 24/Apr/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Anton Korshunov | Assignee: | Mihai Andrei |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | pm2697-m4 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Query Optimization
|
| Backwards Compatibility: | Fully Compatible |
| Sprint: | QE 2023-03-20, QE 2023-04-03, QE 2023-04-17, QE 2023-05-01 |
| Participants: | |
| Story Points: | 5 |
| Comments |
| Comment by Githook User [ 24/Apr/23 ] |
|
Author: {'name': 'Mihai Andrei', 'email': 'mihai.andrei@mongodb.com', 'username': 'mtandrei'}Message: |
| Comment by Mihai Andrei [ 19/Apr/23 ] |
|
Note that there's only one reference to Then, with respect to https://github.com/mongodb/mongo/blob/1382877972003390495e3dfe261ef368e24be163/src/mongo/db/query/canonical_query_encoder.cpp#L702-L704 : this code has been removed by... |
| Comment by David Storch [ 07/Feb/23 ] |
|
mihai.andrei@mongodb.com as part of this ticket we should look into whether this line of code can be simplified: This looks like it is only necessary to ensure that queries using SBE have a different classic plan cache key encoding from the same query using the classic engine. Now that queries using SBE never use the classic plan cache, encoding the "force classic engine" byte into the classic plan cache key presumably isn't necessary anymore. |
| Comment by David Storch [ 18/Apr/22 ] |
|
Please grep for " |