[SERVER-64882] Eliminate fallback code which uses the classic cache when the SBE cache is disabled Created: 24/Mar/22  Updated: 29/Oct/23  Resolved: 24/Apr/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Anton Korshunov Assignee: Mihai Andrei
Resolution: Fixed Votes: 0
Labels: pm2697-m4
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Query Optimization
Backwards Compatibility: Fully Compatible
Sprint: QE 2023-03-20, QE 2023-04-03, QE 2023-04-17, QE 2023-05-01
Participants:
Story Points: 5

 Comments   
Comment by Githook User [ 24/Apr/23 ]

Author:

{'name': 'Mihai Andrei', 'email': 'mihai.andrei@mongodb.com', 'username': 'mtandrei'}

Message: SERVER-64882 Only generate DebugInfoSBE when plan is not from cache
Branch: master
https://github.com/mongodb/mongo/commit/41e18b1bf03ca7b22392663983fa345f9939e6bd

Comment by Mihai Andrei [ 19/Apr/23 ]

Note that there's only one reference to SERVER-64882 in the codebase at the time of writing. I am going to open a PR to remove it (the "big" reference to this ticket was https://github.com/mongodb/mongo/commit/b185d04364c298e701943a1e800c4036ce8df6e7#diff-0154ea2007ca37ba4a4ce4854565b2870c871418090f5f965b18f68afbc05e1aL1183  but it has been removed).

Then, with respect to https://github.com/mongodb/mongo/blob/1382877972003390495e3dfe261ef368e24be163/src/mongo/db/query/canonical_query_encoder.cpp#L702-L704 : this code has been removed by... SERVER-63346

Comment by David Storch [ 07/Feb/23 ]

mihai.andrei@mongodb.com as part of this ticket we should look into whether this line of code can be simplified:

https://github.com/mongodb/mongo/blob/1382877972003390495e3dfe261ef368e24be163/src/mongo/db/query/canonical_query_encoder.cpp#L702-L704

This looks like it is only necessary to ensure that queries using SBE have a different classic plan cache key encoding from the same query using the classic engine. Now that queries using SBE never use the classic plan cache, encoding the "force classic engine" byte into the classic plan cache key presumably isn't necessary anymore.

CC anton.korshunov@mongodb.com

Comment by David Storch [ 18/Apr/22 ]

Please grep for "SERVER-64882" or "TODO SERVER-64882" to find code that needs to be cleaned up before resolving this ticket.

Generated at Thu Feb 08 06:01:22 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.