[SERVER-65046] Use vertical style blocks for listing compile_flags Created: 29/Mar/22  Updated: 29/Oct/23  Resolved: 21/Sep/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Richard Samuels (Inactive) Assignee: Trevor Guidry
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Backwards Compatibility: Fully Compatible
Participants:
Linked BF Score: 69

 Description   

We've historically represented compile_flags as a single line, ex:

compile_flags: --dbg=on --opt=on -j$(grep -c ^processor /proc/cpuinfo) --link-model=dynamic --variables-files=etc/scons/mongodbtoolchain_testing_gcc.vars 

but it's way more readable to list them using YAML's vertical style blocks:

compile_flags: >-
  --dbg=on 
  --opt=on 
  -j$(grep -c ^processor /proc/cpuinfo) 
  --link-model=dynamic
  --variables-files=etc/scons/mongodbtoolchain_testing_gcc.vars 

This ticket represents making a bulk change to all compile_flags expansions. This can also apply to a number of other expansions: csfle_task_compile_flags, task_compile_flags, test_flags, burn_in_tag_buildvariants, additional_package_targets



 Comments   
Comment by Githook User [ 22/Sep/22 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-65046 fix typo in gnu-style long option
Branch: master
https://github.com/mongodb/mongo/commit/9115e5c924377eec14a0d1ed15d27574dec01e09

Comment by Githook User [ 21/Sep/22 ]

Author:

{'name': 'Trevor Guidry', 'email': 'trevor.guidry@mongodb.com'}

Message: SERVER-65046 fix missing quote in enterprise-debian11-64 build
Branch: master
https://github.com/mongodb/mongo/commit/bf191b0361e837a17c743941180a4d77de875a9d

Comment by Githook User [ 20/Sep/22 ]

Author:

{'name': 'Trevor Guidry', 'email': 'trevor.guidry@mongodb.com'}

Message: SERVER-65046 use vertical style blocks for listing compile_flags
Branch: master
https://github.com/mongodb/mongo/commit/9f73407dce3c81bc212c4cee6f500d00c7e0fc12

Generated at Thu Feb 08 06:01:44 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.