[SERVER-65060] Add readability-function-size clang-tidy rule Created: 30/Mar/22 Updated: 07/Feb/23 Resolved: 07/Feb/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Tausif Rahman (Inactive) | Assignee: | [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive) |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Server Development Platform
|
||||||||
| Sprint: | Dev Platform 2022-04-18 | ||||||||
| Participants: | |||||||||
| Description |
|
Add this rule to the .clang-tidy file per stakeholder request. ***This was broken off from |
| Comments |
| Comment by Alex Neben [ 07/Feb/23 ] |
|
The problem with this check is that the enforcement around this can cause an unrelated engineer to need to deal with a problem. If you were the last engineer of 50 to add a line to a function all the sudden the onus falls on you to fix the function even though you barely touched it. |
| Comment by Iryna Zhuravlova [ 04/Apr/22 ] |
|
We do not have a capacity to prioritize this work right now. Instead, we will communicate to Server teams on how to add this feature themselves. robert.guo will ask what model development Server teams would like to do to improve the quality by these kinds of improvements and will edit the ticket to add more info, if we decide to work on it in the future. |
| Comment by Tausif Rahman (Inactive) [ 30/Mar/22 ] |
|
acm That's correct. Maybe the "has to be done after" link is not needed, since this check can technically be added with or without the .clang-tidy file. |