[SERVER-65355] false positive in time_support_test under v4 gcc Created: 07/Apr/22  Updated: 29/Oct/23  Resolved: 08/Apr/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.0.0-rc0

Type: Bug Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Steps To Reproduce:

source python3-venv/bin/activate
rm -rf ./build/debug/install/bin
rm -rf ./build/opt/install/bin
./buildscripts/scons.py --variables-files=etc/scons/mongodbtoolchain_v4_gcc.vars --cxx-std=20 --link-model=dynamic --ssl --ninja generate-ninja ICECC=icecc CCACHE=ccache --dbg=on --modules=""
ninja -j500 install-all
 
 
I get this error:
 
[1900/3062 ( 62%) 51.481s] Compiling build/debug/mongo/util/time_support_test.o
FAILED: build/debug/mongo/util/time_support_test.o 
export PATH='/opt/mongodbtoolchain/v4/bin:/usr/local/bin:/opt/bin:/bin:/usr/bin';export CCACHE_NOCPP2='1';export CCACHE_PREFIX='/home/ubuntu/mongo/build/scons/icecream/debug/run-icecc.sh';/opt/mongodbtoolchain/v4/bin/ccache /opt/mongodbtoolchain/v4/bin/g++ @build/debug/mongo/util/time_support_test.o.rsp
src/mongo/util/time_support_test.cpp: In member function ‘virtual void mongo::{anonymous}::UnitTest_SuiteNameTimeParsingTestNameInvalidDates::_doTest()’:
src/mongo/util/time_support_test.cpp:416:29: error: loop variable ‘s’ of type ‘const string&’ {aka ‘const std::__cxx11::basic_string<char>&’} binds to a temporary constructed from type ‘const char* const’ [-Werror=range-loop-construct]
  416 |     for (const std::string& s : badDates) {
      |                             ^
src/mongo/util/time_support_test.cpp:416:29: note: use non-reference type ‘const string’ {aka ‘const std::__cxx11::basic_string<char>’} to make the copy explicit or ‘const char* const&’ to prevent copying
cc1plus: all warnings being treated as errors
[1923/3062 ( 62%) 52.364s] Linking build/debug/mongo/util/net/libssl_manager.so
ninja: build stopped: subcommand failed.

Sprint: Service Arch 2022-04-18
Participants:
Linked BF Score: 63

 Description   

https://github.com/10gen/mongo/commit/1ddb5b1e8aaa5eca91162b3426e46d9e9e833dfb#r70761745



 Comments   
Comment by Githook User [ 07/Apr/22 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-65355 avoid binding to temporary to silence warning
Branch: master
https://github.com/mongodb/mongo/commit/be3948861204ef3a347538ad2acf1fe33d843e7e

Generated at Thu Feb 08 06:02:31 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.