[SERVER-65424] Test 'explain' output in JS tests for spilling the 'HashAgg' stage to disk in SBE Created: 11/Apr/22  Updated: 29/Oct/23  Resolved: 12/Apr/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.0.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Mohammad Dashti (Inactive) Assignee: Mohammad Dashti (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: QE 2022-04-18
Participants:

 Description   

Currently, there are at least two JS test files that test spilling to disk for the SBE HashAgg stage, i.e., jstests/aggregation/spill_to_disk.js and jstests/noPassthrough/spill_to_disk_secondary_read.js. However, none of these two files check the explain output regarding spilling to disk for the cases that involve an SBE HashAgg stage. To improve it, some assertions on the explain output is preferred, similar to how it's done for the HashLookup stage in SERVER-62676).

In addition, in jstests/aggregation/spill_to_disk.js, the setHashAggParameters function is not setting the parameters properly to support all test fixtures. For example, this test file is not even testing its intended scenario under the aggregation_one_shard_sharded_collections and aggregation_mongos_passthrough test suites. One possible solution is to use the FixtureHelpers.runCommandOnEachPrimary function, similar to how it's done in setHashLookupParameters (as part of SERVER-62676).



 Comments   
Comment by Githook User [ 12/Apr/22 ]

Author:

{'name': 'Mohammad Dashti', 'email': 'mdashti@gmail.com', 'username': 'mdashti'}

Message: SERVER-65424 Added some tests for the `explain` output in JS tests for spilling the `HashAgg` stage to disk in SBE
Branch: master
https://github.com/mongodb/mongo/commit/ff94b90355c5e96d5119c29d8a590ffb500f98fb

Generated at Thu Feb 08 06:02:42 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.