[SERVER-65465] SBE Group should not use DoubleDoubleSummation for count Created: 11/Apr/22 Updated: 29/Oct/23 Resolved: 04/May/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.1.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Geert Bosch | Assignee: | Yoon Soo Kim |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Backport Requested: |
v6.0
|
||||||||||||||||||||||||
| Sprint: | QE 2022-05-02, QE 2022-05-16 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Description |
|
I was surprised to see the following: when profiling
Because we just summing the constant 1, there is no need for compensated summation: we should just count using a 64-bit integer. It won't overflow. |
| Comments |
| Comment by Githook User [ 04/May/22 ] |
|
Author: {'name': 'Yoonsoo Kim', 'email': 'yoonsoo.kim@mongodb.com', 'username': 'yun-soo'}Message: |
| Comment by Geert Bosch [ 26/Apr/22 ] |
|
This may actually be addressed by |