[SERVER-65544] SCons unittest targets should setup a TMPDIR variable Created: 13/Apr/22 Updated: 29/Oct/23 Resolved: 13/May/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.1.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Daniel Moody | Assignee: | Daniel Moody |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Dev Platform 2022-05-16 |
| Participants: |
| Description |
|
The unittests now use wiredtiger and write to disk. BY default they store this in /tmp, but in general scons maintains its build artifacts in the build directory, and so maybe there should be a test_working_data or similar in the build directory were the tests can work and put temp files instead of storing things in /tmp. |
| Comments |
| Comment by Githook User [ 12/May/22 ] |
|
Author: {'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}Message: |
| Comment by Ryan Egesdahl (Inactive) [ 04/May/22 ] |
|
daniel.moody@mongodb.com A clearly-labeled temporary directory in build would be fine to me. I just care that it is identifiable. |
| Comment by Daniel Moody [ 04/May/22 ] |
|
I can add a command line variable so its configureable from the command line. |
| Comment by Daniel Moody [ 04/May/22 ] |
|
Build artifacts are anything produced by the build and build artifacts should be in the build directory IMHO. So I would want to set the TMPDIR to something in the build directory, at the top level of the build directory, and clearly labeled temporary. So unless anyone wants further discussion, I'll assume and proceed with that course of action. |
| Comment by Ryan Egesdahl (Inactive) [ 13/Apr/22 ] |
|
I think the build/ directory should mostly be for build artifacts, not test data. We usually put our test data in /data by default or wherever we root our build topdir in Evergreen. Test artifacts should probably be placed in something like /data/tmp or the like. |