[SERVER-65581] Errors reported from ESLint/ClangTidy are extremely difficult to locate Created: 13/Apr/22 Updated: 29/Oct/23 Resolved: 31/May/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.1.0-rc0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Kaloian Manassiev | Assignee: | Richard Samuels (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | ALL | ||||||||||||
| Sprint: | Dev Platform 2022-05-16, Dev Platform 2022-05-30 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
The eslint task outputs about 500 lines of log output of which only a couple are the actual error. In this example, the actual error is buried somewhere in the middle and is in the same colour as the rest of the log, therefore extremely hard to visually locate:
This is not an issue with just ESLint, ClangTidy has the same problem and outputs even more log, some of which is highlighted in red, but this is a "red herring". We should do a better job at highlighting these errors. Perhaps we can remove some of the other log which is being reported as part of the task and redirect it to a different tab. For example, not sure why as someone who is changing code in the core server do I need to see this:
|
| Comments |
| Comment by Richard Samuels (Inactive) [ 31/May/22 ] |
|
This change generates reports for our lint_* tasks and clang_tidy. Here's a sample log from clang_tidy that shows that we isolate the logs into the tests section, and also discard much of the noise (e.g. "[n] warnings generated"). For clang_tidy, we also remove duplicate error messages, such as those that emerge when an error is introduced in a header included by multiple translation units. For the existing lint_* tasks, we just isolate the stdout from the linter. |
| Comment by Githook User [ 20/May/22 ] |
|
Author: {'name': 'Richard Samuels', 'email': 'richard.l.samuels@gmail.com', 'username': 'richardsamuels'}Message: |
| Comment by Richard Samuels (Inactive) [ 16/May/22 ] |
|
Logs will be ingested as a single line by our changes for this ticket. Please see EVG-16886 for a bug fix I've requested. |