[SERVER-656] ismaster command should be readonly Created: 23/Feb/10  Updated: 12/Jul/16  Resolved: 26/Feb/10

Status: Closed
Project: Core Server
Component/s: Concurrency
Affects Version/s: None
Fix Version/s: 1.3.3

Type: Improvement Priority: Minor - P4
Reporter: Dwight Merriman Assignee: Aaron Staple
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Participants:

 Description   

ismaster command is not readnoly, and that could result in unexpected blocks for replica pair users. please make the command readOnly(), after checking that the code is thread-safe. (is it?)



 Comments   
Comment by Eliot Horowitz (Inactive) [ 26/Feb/10 ]

did this as part of SERVER-674

Comment by Aaron Staple [ 23/Feb/10 ]

Just reopening so I remember to investigate the new command option.

Comment by Aaron Staple [ 23/Feb/10 ]

I already reused noLocking() in another command, so hopefully it's relatively reliable. Will check it out though.

Comment by Eliot Horowitz (Inactive) [ 23/Feb/10 ]

its actually completely non-blocking at the moment.
i added a new
virtual bool noLocking()

{ return true; }

method to commands

aaron, can you double check anyway?

at some point i want to change the command interface a bit because there are a few methods that could conflict.

maybe have them not override, but have a cons argument, not sure

Generated at Thu Feb 08 02:54:47 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.