[SERVER-65782] Update view graph collator to be a shared_ptr Created: 19/Apr/22 Updated: 06/Dec/22 Resolved: 12/Sep/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Shin Yee Tan | Assignee: | Backlog - Storage Execution Team |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Storage Execution
|
| Participants: |
| Description |
|
Every view graph node has its own copy of the collator. We should consider using a shared_ptr since all operations on the collator seem to be const. There may be other places that can also share this pointer ie. view definition |
| Comments |
| Comment by Dan Larkin-York [ 19/Apr/22 ] |
|
If we mainly care about cleaning up and simplifying the copying code, we could use a clonable_ptr instead of unique_ptr to get clean copy semantics without dealing with shared ownership. But if it turns out the copy is somewhat expensive, then shared_ptr might be worth it. |