[SERVER-65892] `Shard::runCommandWithFixedRetryAttempts` must not ignore OperationContext's deadline Created: 22/Apr/22 Updated: 12/Dec/23 |
|
| Status: | Backlog |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Pierlauro Sciarelli | Assignee: | Backlog - Cluster Scalability |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | sharding-nyc-subteam2, sharding-wfbf-day | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Assigned Teams: |
Cluster Scalability
|
||||||||||||||||||||
| Backwards Compatibility: | Minor Change | ||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||
| Sprint: | Sharding EMEA 2022-05-16, Sharding NYC 2023-06-26, Sharding NYC 2023-07-10, Sharding NYC 2023-07-24, Sharding NYC 2023-08-07, Sharding NYC 2023-08-21, Sharding NYC 2023-09-04, Sharding NYC 2023-09-18, Sharding NYC 2023-10-02, Sharding NYC 2023-10-16 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Linked BF Score: | 164 | ||||||||||||||||||||
| Story Points: | 3 | ||||||||||||||||||||
| Description |
|
The deadline is set to Milliseconds::max and the timeout from the operation context is only checked before performing network requests , meaning that the timeout is not respected in case the network request hangs or requires too long. |
| Comments |
| Comment by Githook User [ 09/Aug/23 ] |
|
Author: {'name': 'Uladzimir Makouski', 'email': 'uladzimir.makouski@mongodb.com', 'username': 'umakouski'}Message: Revert "SERVER-65892 Lower timeout for runCommand" This reverts commit 2b56ae2981b98d819b06543c92b0c9c77b6c6160. |
| Comment by Antonio Fuschetto [ 09/Aug/23 ] |
|
Hi kruti.shah@mongodb.com. Limiting the timeout of network requests to 60 seconds is causing the _configsvrMoveRange command to fail in CI (see hot BF-29572), so I suggest to reconsider the implementation of this ticket. In the meantime, I'm requesting a commit revert. |
| Comment by Githook User [ 08/Aug/23 ] |
|
Author: {'name': 'Kruti Shah', 'email': 'kruti139@gmail.com', 'username': 'krutishah139'}Message: SERVER-65892 Lower timeout for runCommand |
| Comment by Marcos José Grillo Ramirez [ 16/May/22 ] |
|
PM-2399 will change the API that would change with this ticket. Adding it to the project so it can serve as a warning of the current behavior that should also be addressed by the project. |