[SERVER-65901] scons.py silently ignores invalid "variable-files" parameter Created: 22/Apr/22  Updated: 29/Oct/23  Resolved: 28/Jul/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Randolph Tan Assignee: Richard Samuels (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v6.1, v6.0, v5.0, v4.4, v4.2
Sprint: Dev Platform 2022-05-30, Dev Platform 2022-06-13, Dev Platform 2022-06-27, Dev Platform 2022-07-11, Dev Platform 2022-07-25
Participants:

 Description   

example:

buildscripts/scons.py --variable-files=etc/scons/mongodbtoolchain_stable_gcc.vars compiledb



 Comments   
Comment by Githook User [ 28/Jul/22 ]

Author:

{'name': 'Richard Samuels', 'email': 'richard.l.samuels@gmail.com', 'username': 'richardsamuels'}

Message: SERVER-65901 scons.py silently ignores invalid variable-files parameter
Branch: master
https://github.com/mongodb/mongo/commit/e1c7b19f7e2379e43ae7837193f36a255d66e273

Comment by Githook User [ 27/Jul/22 ]

Author:

{'name': 'Richard Samuels', 'email': 'richard.l.samuels@gmail.com', 'username': 'richardsamuels'}

Message: Revert "SERVER-65901 scons.py silently ignores invalid variable-files parameter"

This reverts commit 10d28f2eb868656fbde804df0cb2ef9cf3934125.
Branch: master
https://github.com/mongodb/mongo/commit/a55985b97d49d119f298710850a6d63cc63c786a

Comment by Githook User [ 27/Jul/22 ]

Author:

{'name': 'Richard Samuels', 'email': 'richard.l.samuels@gmail.com', 'username': 'richardsamuels'}

Message: SERVER-65901 scons.py silently ignores invalid variable-files parameter
Branch: master
https://github.com/mongodb/mongo/commit/10d28f2eb868656fbde804df0cb2ef9cf3934125

Comment by Ryan Egesdahl (Inactive) [ 09/Jun/22 ]

SCons is supposed to be able to detect unknown flags on its own, but that happens after all of the SConscript (and SConstruct) files have been processed. This option in particular is needed during SConstruct to even make sure a usable toolchain is selected, so we will need to roll our own unknown flag detection to make it work for all cases.

Comment by Andrew Morrow (Inactive) [ 22/Apr/22 ]

We have logic that looks for unknown VARIABLES but it isn't clear SCons offers a similar API to detect unknown flags. We may need to roll our own.

Generated at Thu Feb 08 06:03:56 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.