[SERVER-65927] Annotate switch fallthrough in bson_validate_old.cpp Created: 25/Apr/22  Updated: 29/Oct/23  Resolved: 27/Apr/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.1.0-rc0

Type: Bug Priority: Major - P3
Reporter: Gregory Noma Assignee: Gregory Noma
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Related
related to SERVER-55204 Opt in to -Wimplicit-fallthrough in s... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Execution Team 2022-05-02
Participants:
Linked BF Score: 65

 Description   

After SERVER-55204, non-trivial switch statement fallthrough must be annotated with [[fallthrough]]. There's a case of this in need of the annotation in bson_validate_old.cpp.



 Comments   
Comment by Githook User [ 27/Apr/22 ]

Author:

{'name': 'Gregory Noma', 'email': 'gregory.noma@gmail.com', 'username': 'gregorynoma'}

Message: SERVER-65927 Annotate switch fallthrough in `bson_validate_old.cpp`
Branch: master
https://github.com/mongodb/mongo/commit/0eec3d7e2e48d8c64ebc5834281407d8c27deb52

Comment by Andrew Morrow (Inactive) [ 27/Apr/22 ]

gregory.noma@mongodb.com - Sorry for the breakage, it looks like the fuzzer tests only get compiled when built with --sanitizer=fuzzer so my "all" build looking for places that needed an added [[fallthrough]] was apparently more of an all-ish build. Thanks for taking on fixing this up.

Generated at Thu Feb 08 06:04:01 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.