[SERVER-66203] Sweep: move MONGO_LOGV2_DEFAULT_COMPONENT definition below includes Created: 03/May/22 Updated: 29/Oct/23 Resolved: 06/May/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.1.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Billy Donahue | Assignee: | Billy Donahue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||||||
| Sprint: | Service Arch 2022-05-16 | ||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||||||||||||||||||
| Description |
|
Doing this makes it possible for headers to define (and then undef) the macro internally without worrying that another file has already defined it. This could be accomplished with nonstandard push_macro/pop_macro but that's complicated and nonstandard. We can do better. Doing this also makes a cleaner precompiled header / modules / caching model because headers will not be included multiple times with different values of MONGO_LOGV2_DEFAULT_COMPONENT. It mitigates one definition rule risk by the same logic. [split from SERVER-52604] I'm just running a script I already had from last year. |
| Comments |
| Comment by Githook User [ 06/May/22 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: |
| Comment by Githook User [ 06/May/22 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: |
| Comment by Githook User [ 06/May/22 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: |
| Comment by Billy Donahue [ 03/May/22 ] |
|
https://gist.github.com/BillyDonahue/48c2746b9a761e1d1ecc930486d83aa5 |