[SERVER-66282] BGHook doesn't stop its background thread after a test failure Created: 06/May/22 Updated: 06/Dec/22 |
|
| Status: | Open |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Vishnu Kaushik | Assignee: | Backlog - Replication Team |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Replication
|
| Operating System: | ALL |
| Sprint: | Repl 2022-05-16, Repl 2022-05-30, Repl 2022-06-13, Repl 2022-06-27, Repl 2022-07-11, Repl 2022-08-08, Repl 2022-08-22, Repl 2022-09-05, Repl 2022-07-25 |
| Participants: |
| Description |
|
BGHook should determine if a test failure has occurred, and if so, should get its background thread to rejoin. This should be possible by adding a check in the after_test method, here. |
| Comments |
| Comment by Vishnu Kaushik [ 10/May/22 ] |
|
We were talking about who will maintain this hook in the long run, and if that might be the STM team. Here is robert.guo@mongodb.com's response: So I would expect the files to not break by themselves, otherwise we’d need to collectively maintain an ever increasing set of code. If someone wants to make a change in BGHook, I would expect it to be self-service. If someone needs to change one of the descendent classes, it would go to the team that owns the class. My teams are working on a way to move away from the randomized hook-styled testing and won’t be contributing to improvements, so I don’t want to give people the illusion that we will be doing work there by claiming ownership. But happy to discuss any questions or areas of concern in the resmoke hook system. |