[SERVER-66333] Make consistent notifyChangeStreams API Created: 10/May/22  Updated: 06/Dec/23

Status: Open
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Bernard Gorman Assignee: Sebastien Mendez
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Query Execution
Participants:

 Description   

After PM-1950, there are an increasing number of places where we write a no-op oplog message to signify to change streams that a particular event has occurred. Most of these places are now named notifyChangeStreamsOn* but are scattered throughout the code. We should make sure that ALL such no-op writers are named notifyChangeStreamsOn (e.g. the shardCollection no-op writer is currently just called _writeOplogMessage, the reshardBegin and reshardDoneCatchUp events are not in separate functions at all) and consolidate these into a dedicated library and API.



 Comments   
Comment by Bernard Gorman [ 27/May/22 ]

Note: as of SERVER-63437, this library has been created and the shardCollection no-op write has been renamed and moved into it. The remaining functions still need to be consolidated into change_stream_oplog_notification. Additionally, as long as it doesn't cause any dependency or other issues, the notifyChangeStreamsOnShardCollection function should really take a const CreateCollectionRequest& as its argument rather than a raw BSONObj.

Generated at Thu Feb 08 06:05:08 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.