[SERVER-66376] Support stable_timestamp usage changes in WiredTiger Created: 11/May/22  Updated: 27/Oct/23  Resolved: 16/May/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Will Korteland Assignee: Backlog - Storage Execution Team
Resolution: Works as Designed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Storage Execution
Participants:

 Description   

As part of WT-9186, wt_txn_validate_commit_timestamp is changing the way it validates the commit timestamp. Now that we don't have out-of-order timestamps, we can (correctly) compare the commit timestamp of the first update on the update chain with the stable timestamp, instead of the commit timestamp from (say) session->timestamp_transaction("commit_timestamp=...").

There seems to be a non-zero amount of server fallout from this change, I've linked a patch build in the comments. This will need to be investigated/fixed before we can include this change in WT.



 Comments   
Comment by Will Korteland [ 16/May/22 ]

Ok, thanks for the advice louis.williams@mongodb.com. I'll close this since there doesn't seem to be an issue with this change.

Comment by Louis Williams [ 12/May/22 ]

will.korteland@mongodb.com, yes, I would say that if the patch build is green (except for known failures), then MongoDB appears to not be violating this assertion. If we merge this change, then we can let the more randomized tests run more times to give us more confidence.

Comment by Will Korteland [ 11/May/22 ]

Oh, that's good news. Would you say the amount of test coverage in that build is adequate? It would be nice if I could keep moving ahead with my ticket knowing that it doesn't break anything for the rest of the server.

Generated at Thu Feb 08 06:05:15 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.