[SERVER-66466] Remove TransportLayerASIOTest dependence on ThreadContext Created: 14/May/22 Updated: 29/Oct/23 Resolved: 16/May/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.15, 5.0.15, 6.0.4, 6.1.0-rc0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Billy Donahue | Assignee: | Billy Donahue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | ALL | ||||||||||||
| Backport Requested: |
v6.0, v5.0, v4.4
|
||||||||||||
| Sprint: | Service Arch 2022-05-30 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
TransportLayerASIOTest is the last user of ThreadContext. It's the only reason we have it. And because we have it, we have to have a ThreadContext::get call in every thread we spawn (and we'll still miss some threads). It's a flaky test and what it's using ThreadContext for can be done with dependency injection, more reliably. Then we can have a better test and proceed to get rid of ThreadContext (per |
| Comments |
| Comment by Githook User [ 05/Dec/22 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: (cherry picked from commit df9f792d75db8efd8cd697c954d7fce291b3def6) |
| Comment by Githook User [ 22/Nov/22 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: (cherry picked from commit df9f792d75db8efd8cd697c954d7fce291b3def6) |
| Comment by Githook User [ 08/Jun/22 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: (cherry picked from commit df9f792d75db8efd8cd697c954d7fce291b3def6) |
| Comment by Githook User [ 16/May/22 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: |