[SERVER-66466] Remove TransportLayerASIOTest dependence on ThreadContext Created: 14/May/22  Updated: 29/Oct/23  Resolved: 16/May/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.4.15, 5.0.15, 6.0.4, 6.1.0-rc0

Type: Bug Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Issue split
split from SERVER-66456 remove ThreadContext Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v6.0, v5.0, v4.4
Sprint: Service Arch 2022-05-30
Participants:

 Description   

TransportLayerASIOTest is the last user of ThreadContext.

It's the only reason we have it. And because we have it, we have to have a ThreadContext::get call in every thread we spawn (and we'll still miss some threads).

It's a flaky test and what it's using ThreadContext for can be done with dependency injection, more reliably. Then we can have a better test and proceed to get rid of ThreadContext (per SERVER-66456).



 Comments   
Comment by Githook User [ 05/Dec/22 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-66466 TransportLayerASIOTest remove ThreadContext

(cherry picked from commit df9f792d75db8efd8cd697c954d7fce291b3def6)
Branch: v5.0
https://github.com/mongodb/mongo/commit/1f16829e38ab24e820547e78c048d31b9946f09a

Comment by Githook User [ 22/Nov/22 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-66466 TransportLayerASIOTest remove ThreadContext

(cherry picked from commit df9f792d75db8efd8cd697c954d7fce291b3def6)
Branch: v6.0
https://github.com/mongodb/mongo/commit/589d28dbe5477fb34db6ad952bec094fcbd385a2

Comment by Githook User [ 08/Jun/22 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-66466 TransportLayerASIOTest remove ThreadContext

(cherry picked from commit df9f792d75db8efd8cd697c954d7fce291b3def6)
Branch: v4.4
https://github.com/mongodb/mongo/commit/bc17cf2c788c5dda2801a090ea79da5ff7d5fac9

Comment by Githook User [ 16/May/22 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-66466 TransportLayerASIOTest remove ThreadContext
Branch: master
https://github.com/mongodb/mongo/commit/df9f792d75db8efd8cd697c954d7fce291b3def6

Generated at Thu Feb 08 06:05:31 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.