[SERVER-66587] Rename isEnabledAndIgnoreFCV() to be isEnabledAndIgnoreFCVUnsafe() and audit usages Created: 19/May/22 Updated: 29/Oct/23 Resolved: 05/Apr/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.0.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Huayu Ouyang | Assignee: | Jiawei Yang |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | milestone-2, pm-2821-quick-wins | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Assigned Teams: |
Replication
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Sprint: | Repl 2023-04-03, Repl 2023-04-17 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Description |
|
We should rename isEnabledAndIgnoreFCV() to be isEnabledAndIgnoreFCVUnsafe() and require any usages to have a comment in some number of lines preceding it. This is because we want to avoid using isEnabledAndIgnoreFCV() in general For places where commands and aggregation states/expressions are registered that use isEnabledAndIgnoreFCV, we should add a function isEnabledAndIgnoreFCVAtStartup() which has the same behavior as isEnabledAndIgnoreFCVUnsafe() but won’t require a comment. We should also add better documentation about when to use isEnabled vs isEnabledAndIgnoreFCVAtStartup |
| Comments |
| Comment by Githook User [ 05/Apr/23 ] |
|
Author: {'name': 'Jiawei Yang', 'email': 'jiawei.yang@mongodb.com', 'username': 'YoungYang0820'}Message: |