[SERVER-66736] jstests/libs/test_background_ops.js redefines startParallelShell function Created: 24/May/22  Updated: 29/Oct/23  Resolved: 30/Jun/22

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 6.1.0-rc0

Type: Bug Priority: Major - P3
Reporter: Max Hirschhorn Assignee: Abdul Qadeer
Resolution: Fixed Votes: 0
Labels: sharding-nyc-subteam1
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Problem/Incident
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Sharding 2022-06-27, Sharding 2022-07-11
Participants:
Linked BF Score: 149
Story Points: 2

 Description   

jstests/libs/test_background_ops.js redefines the startParallelShell() function built into the mongo shell. The definition in jstests/libs/test_background_ops.js won't throw a JavaScript exception even if the parallel shell exits with a non-zero return code.

The following tests appear to call one of startParallelShell(), startParallelOps(), or moveChunkParallel() and either directly or indirectly end up loading jstests/libs/test_background_ops.js:

  • jstests/change_streams/change_streams_lookup_preimage_with_chunk_migration.js
  • jstests/multiVersion/genericBinVersion/minor_version_upgrade_replset.js
  • jstests/multiVersion/genericSetFCVUsage/3_upgrade_replset.js
  • jstests/multiVersion/genericSetFCVUsage/downgrade_replset.js
  • jstests/noPassthrough/create_indexes_in_txn_errors_if_already_in_progress.js
  • jstests/noPassthroughWithMongod/create_indexes_waits_for_already_in_progress.js
  • jstests/noPassthroughWithMongod/create_new_indexes_with_conflict.js
  • jstests/replsets/ddl_op_behind_transaction_fails_in_shutdown.js
  • jstests/replsets/reconfig_avoids_diverging_configs.js
  • jstests/sharding/bump_transaction_prevents_extra_deletion_task_write.js
  • jstests/sharding/index_commands_shard_targeting.js
  • jstests/sharding/migration_critical_section_concurrency.js
  • jstests/sharding/migration_ignore_interrupts_1.js
  • jstests/sharding/migration_ignore_interrupts_2.js
  • jstests/sharding/migration_move_chunk_after_receive.js
  • jstests/sharding/migration_recovers_unfinished_migrations.js
  • jstests/sharding/migration_server_status.js
  • jstests/sharding/migration_sets_fromMigrate_flag.js
  • jstests/sharding/migration_waits_for_majority_commit.js
  • jstests/sharding/migration_with_source_ops.js
  • jstests/sharding/move_chunk_remove_shard.js
  • jstests/sharding/move_chunk_update_shard_key_in_retryable_write.js
  • jstests/sharding/movechunk_parallel.js
  • jstests/sharding/prepare_transaction_then_migrate.js
  • jstests/sharding/recover_multiple_migrations_on_stepup.js
  • jstests/sharding/safe_secondary_reads_causal_consistency.js
  • jstests/sharding/txn_writes_during_movechunk.js
  • jstests/sharding/unfinished_migration_server_status.js
  • jstests/sharding/write_transactions_during_migration.js


 Comments   
Comment by Githook User [ 29/Jun/22 ]

Author:

{'name': 'Abdul Qadeer', 'email': 'abdul.qadeer@mongodb.com', 'username': 'zorro786'}

Message: SERVER-66736 Remove redefined startParallelShell() and fix tests
Branch: master
https://github.com/mongodb/mongo/commit/e752fb4a797c23de6a4cba70fe59f497ce9a8247

Comment by Githook User [ 23/Jun/22 ]

Author:

{'name': 'Abdul Qadeer', 'email': 'abdul.qadeer@mongodb.com', 'username': 'zorro786'}

Message: Revert "SERVER-66736 Remove redefined startParallelShell() and fix test"
Branch: master
https://github.com/mongodb/mongo/commit/9b0e1175ba3176c901c8afc4757293ddef5da445

Comment by Githook User [ 23/Jun/22 ]

Author:

{'name': 'Abdul Qadeer', 'email': 'abdul.qadeer@mongodb.com', 'username': 'zorro786'}

Message: SERVER-66736 Remove redefined startParallelShell() and fix test
Branch: davish/SERVER-63099
https://github.com/mongodb/mongo/commit/0113dc3c9b5bc4d677e8a304dd6dc6e26581c183

Comment by Githook User [ 23/Jun/22 ]

Author:

{'name': 'Abdul Qadeer', 'email': 'abdul.qadeer@mongodb.com', 'username': 'zorro786'}

Message: SERVER-66736 Remove redefined startParallelShell() and fix test
Branch: master
https://github.com/mongodb/mongo/commit/0113dc3c9b5bc4d677e8a304dd6dc6e26581c183

Generated at Thu Feb 08 06:06:17 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.