[SERVER-66861] FSM tests should reset the FCV to the fixture default value Created: 30/May/22  Updated: 29/Aug/22  Resolved: 29/Aug/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: 5.0.9, 6.0.0-rc7
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Tommaso Tocci Assignee: Marcos José Grillo Ramirez
Resolution: Won't Do Votes: 0
Labels: sharding-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Operating System: ALL
Sprint: Sharding EMEA 2022-06-27, Sharding EMEA 2022-07-11, Sharding EMEA 2022-07-25, Sharding EMEA 2022-08-08, Sharding EMEA 2022-08-22, Sharding EMEA 2022-09-05
Participants:

 Description   

Some of our FSM tests modify the FCV but they don't reset it during the teardown. This means that any subsequent test that will be executed afterwards using the same cluster will run with an unexpected FCV.

A non-exaustive list of FSM tests that change the FCV:

  • jstests/concurrency/fsm_workloads/autosplit_setFCV_downgrade_from_60.js
  • jstests/concurrency/fsm_workloads/random_DDL_setFCV_operations.js
  • jstests/concurrency/fsm_workloads/drop_database_sharded_setFCV.js
  • jstests/concurrency/fsm_workloads/random_internal_transactions_setFCV_operations.js
  • jstests/concurrency/fsm_workloads/random_DDL_CRUD_setFCV_operations.js


 Comments   
Comment by Marcos José Grillo Ramirez [ 29/Aug/22 ]

Closing this ticket because all FSM tests already include the resetting of the FCV on the teardown function.

About Tommaso's idea, there is a bigger concern about modifying the python scripts, and is the fact that if we decide to run some test with older FCV's and we create a variant for this, after the execution of the first test the FCV would be set back and we wouldn't even notice. There is interest in finding a better solution to the FCV testing in FSM's, but this needs to be discussed.

Comment by Tommaso Tocci [ 03/Jun/22 ]

I'm wondering if we could achieve this by modifying buildscripts/resmokelib/testing/hooks/cleanup_concurrency_workloads.py to ensure that at the end of every test we reset the FCV to the original value.

Generated at Thu Feb 08 06:06:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.