[SERVER-66938] Drastically simplify command to generate ninja files Created: 01/Jun/22  Updated: 29/Oct/23  Resolved: 30/Jun/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.0.1, 4.4.16, 5.0.11, 6.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Alex Neben Assignee: Tausif Rahman (Inactive)
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Duplicate
Related
is related to SERVER-49467 Introduce a new --build-type flag to ... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v6.0, v5.0, v4.4
Sprint: Dev Platform 2022-06-27, Dev Platform 2022-07-11
Participants:

 Description   

Here is the command to generate an asan ninja file

python ./buildscripts/scons.py --variables-files=./etc/scons/mongodbtoolchain_stable_clang.vars --allocator=system --sanitize=address --link-model=dynamic --dbg --ninja generate-ninja ICECC=icecc CCACHE=ccache NINJA_PREFIX=asan VARIANT_DIR=asan --variables-files=etc/scons/developer_versions.vars 

Note that "--variables-files=etc/scons/developer_versions.vars" is on a trial run so we should not include it (for now)

We should make this command a one or two liner

Something like

./buildscripts/ninja-asan.py

An added benefit of this is that we get a layer of abstraction so we can change small things about the command but the result will be an ASAN build which is what a developer expects.



 Comments   
Comment by Githook User [ 27/Jul/22 ]

Author:

{'name': 'Tausif Rahman', 'email': 'tausif.rahman@mongodb.com', 'username': 'trahman1318'}

Message: SERVER-66938 Drastically simplify command to generate ninja files

(cherry picked from commit 0dd56eb0358262ee0af4d2b172ec53c62ebb0233)
Branch: v5.0
https://github.com/mongodb/mongo/commit/5b9d243e83a567ad42c5723037267f113bc28418

Comment by Githook User [ 26/Jul/22 ]

Author:

{'name': 'Tausif Rahman', 'email': 'tausif.rahman@mongodb.com', 'username': 'trahman1318'}

Message: SERVER-66938 Drastically simplify command to generate ninja files

(cherry picked from commit 0dd56eb0358262ee0af4d2b172ec53c62ebb0233)
Branch: v4.4
https://github.com/mongodb/mongo/commit/6d9f30634bd763c06c903c26b973272d8e9fb2d6

Comment by Githook User [ 26/Jul/22 ]

Author:

{'name': 'Tausif Rahman', 'email': 'tausif.rahman@mongodb.com', 'username': 'trahman1318'}

Message: SERVER-66938 Drastically simplify command to generate ninja files

(cherry picked from commit 0dd56eb0358262ee0af4d2b172ec53c62ebb0233)
Branch: v6.0
https://github.com/mongodb/mongo/commit/a6e5b4986e7bc21080a0fcce8b9ceef89214d48b

Comment by Githook User [ 29/Jun/22 ]

Author:

{'name': 'Tausif Rahman', 'email': 'tausif.rahman@mongodb.com', 'username': 'trahman1318'}

Message: SERVER-66938 Drastically simplify command to generate ninja files
Branch: master
https://github.com/mongodb/mongo/commit/0dd56eb0358262ee0af4d2b172ec53c62ebb0233

Comment by Iryna Zhuravlova [ 13/Jun/22 ]

ryan.egesdahl@mongodb.com and daniel.moody@mongodb.com  to find a "build type" ticket to link here

Generated at Thu Feb 08 06:06:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.