|
mark.benvenuto@mongodb.com so I was looking to see if I could use your script from some data collection I currently am doing. As part of that I was hoping to adapt it to use for our clang-tidy since python > bash. However, the problem with that script is that it only runs on clang-tidy files identified in the diff.
Let us say that dev1 ONLY changed a templated function (functionP) in a headerA.h. However, that change was from
to
...
|
if (p) { delete p; }
|
...
|
which should trigger https://releases.llvm.org/7.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-delete-null-pointer.html
clang-tidy would only warn about this after someone else changes a file that has an instantiation of functionP.
Now that is not to say it is not a good starting point for me but I just want to message out that this is not a viable way to speed up the commit queue part of clang-tidy. I think the best way is to use icecream (or another distributed execution environment) to run them completely in parallel.
|