[SERVER-67143] Eliminate unreachable code related to OP_QUERY in dbclient_rs.cpp Created: 08/Jun/22  Updated: 29/Oct/23  Resolved: 23/Jun/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: David Storch Assignee: David Storch
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: QE 2022-06-27
Participants:

 Description   

There are a few blocks of code in the implementation of DBClientReplicaSet which should only execute if the client is running OP_QUERY operations. As far as I know, there should be know circumstance in which a 6.0+ shell, mongod, or mongos would ever execute an OP_QUERY. Therefore, this code is theoretically unreachable and should be removed:

The work for this ticket is to confirm that this logic is indeed unreachable, and if so remove it.



 Comments   
Comment by Githook User [ 23/Jun/22 ]

Author:

{'name': 'David Storch', 'email': 'david.storch@mongodb.com', 'username': 'dstorch'}

Message: SERVER-67143 Delete some unused internal client code
Branch: davish/SERVER-63099
https://github.com/mongodb/mongo/commit/57e39f6e07a7aee960f98c4f57c575ff6a203934

Comment by Githook User [ 23/Jun/22 ]

Author:

{'name': 'David Storch', 'email': 'david.storch@mongodb.com', 'username': 'dstorch'}

Message: SERVER-67143 Delete some unused internal client code
Branch: master
https://github.com/mongodb/mongo/commit/57e39f6e07a7aee960f98c4f57c575ff6a203934

Generated at Thu Feb 08 06:07:24 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.