[SERVER-67416] Always sort fieldpath string sets using custom comparator Created: 21/Jun/22 Updated: 29/Oct/23 Resolved: 06/Jul/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.1.0-rc0, 6.0.5 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Steve Tarzia | Assignee: | Steve Tarzia |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Backport Requested: |
v6.0
|
||||||||||||||||||||
| Sprint: | QO 2022-06-27, QO 2022-07-11 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Description |
|
Whenever we store sets of field paths strings (eg., ["a.b", "a", "c.d"]) use a custom string comparator that treats "." as the first character. This is to protect us against future bugs like |
| Comments |
| Comment by Githook User [ 19/Jan/23 ] |
|
Author: {'name': 'Steve Tarzia', 'email': 'steve.tarzia@mongodb.com', 'username': 'starzia'}Message: |
| Comment by Githook User [ 19/Jan/23 ] |
|
Author: {'name': 'Steve Tarzia', 'email': 'steve.tarzia@mongodb.com', 'username': 'starzia'}Message: |
| Comment by Steve Tarzia [ 09/Jan/23 ] |
|
Will backport to v6.0 to fix a plan generation bug explained in this comment in BF-27387 |
| Comment by Steve Tarzia [ 06/Jul/22 ] |
|
The patch for this seems to fix some instances of a long-standing query correctness bug (SERVER-23229), but we should do more investigation to find and add the test cases that still fail. It's doubtful that that bug was really fixed by this. Edit: My mistake – I confirmed that SERVER-23229 is not at all related to the work on this ticket. |
| Comment by Githook User [ 06/Jul/22 ] |
|
Author: {'name': 'Steve Tarzia', 'email': 'steve.tarzia@mongodb.com', 'username': 'starzia'}Message: |
| Comment by Githook User [ 06/Jul/22 ] |
|
Author: {'name': 'Steve Tarzia', 'email': 'steve.tarzia@mongodb.com', 'username': 'starzia'}Message: |
| Comment by Steve Tarzia [ 05/Jul/22 ] |
|
Passed all tests here: https://spruce.mongodb.com/version/62bf72ef57e85a3859f459d8/tasks Resolved merge conflicts and created mergeQueue patch here:
|