[SERVER-67425] ServiceStateMachineTest: separate mock and utility types from the fixture Created: 21/Jun/22 Updated: 05/Aug/22 Resolved: 05/Aug/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Billy Donahue | Assignee: | Alex Li |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | Service Arch 2022-07-11, Service Arch 2022-07-25, Service Arch 2022-08-08, Service Arch 2022-08-22 |
| Participants: |
| Description |
|
There's a lot of clutter to support these little enums and helper functions and mocks. It makes the fixture's true logic harder to tease out. The biggest of these is StepRunner. This should be separated out. The ServiceStateMachineTest fixture should just make instances of these types and manipulate these instances. They don't need their definitions inlined into the fixture class. ServiceStateMachineTest: give more descriptive names to these while we're at it: struct Data enum IngressState enum IngressMode |
| Comments |
| Comment by Githook User [ 05/Aug/22 ] |
|
Author: {'name': 'Alex Li', 'email': 'alex.li@mongodb.com', 'username': 'lia394126'}Message: |
| Comment by Githook User [ 21/Jul/22 ] |
|
Author: {'name': 'Alex Li', 'email': 'alex.li@mongodb.com', 'username': 'lia394126'}Message: |