[SERVER-67426] ServiceStateMachineTest: simplify function templates into ordinary functions Created: 21/Jun/22  Updated: 12/Aug/22  Resolved: 12/Aug/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Alex Li
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-68723 align SessionWorkflowTest with mockin... Closed
Sprint: Service Arch 2022-07-11, Service Arch 2022-07-25, Service Arch 2022-08-08, Service Arch 2022-08-22
Participants:

 Description   

Make all these template functions into regular functions that take enum arguments.
Example:

template <IngressState kState, IngressMode kMode>
void expectNextState() {

Convert this to:

void expectNextState(IngressState state, IngressMode mode) {

There doesn't appear to be a reason for these to be templates, and the template syntax and dispatching is making the code harder to read and understand.


Generated at Thu Feb 08 06:08:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.